You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
hey @MathNya, in this PR i have tried to reduce the memory usage my reducing the collection of iterator into Vec as much as possible and lazily evaluate as many values required. This may slightly reduce the memory that the program uses. Also I have added some changes to internal function signature to be more generic.
error: this argument is passed by value, but not consumed in the function body
--> src/structs/chart.rs:335:33
|
335 | area_chart_series_list: Vec<&str>,
| ^^^^^^^^^ help: consider changing the type to: &[&str]
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.97.0/index.html#needless_pass_by_value
= note: -D clippy::needless-pass-by-value implied by -D warnings
= help: to override -D warnings add #[allow(clippy::needless_pass_by_value)]
Here the function in reference new_chart(..) is a pub fn, if changes as asked by clippy are implemented then it would break the API surface. Kindly resolve this either denying the lint for this function or accepting the breaking change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hey @MathNya, in this PR i have tried to reduce the memory usage my reducing the collection of iterator into
Vecas much as possible and lazily evaluate as many values required. This may slightly reduce the memory that the program uses. Also I have added some changes to internal function signature to be more generic.